Show info about missing users in schedules #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brojd
added
release:enhancement
brojd
changed the title
brojd
commented
Apr 29, 2024
| font-weight: 500; | ||
| pointer-events: none; |
There was a problem hiding this comment.
This one blocked showing tooltip within schedule slot, it was added long time ago and as far as I tested, everything works without it. But if you remember some context about it @maskin25 , pls let me know
There was a problem hiding this comment.
hmm, I haven't seen any issues with tooltip over schedule slot, and tooltip is attached to a higher level container, not to the title element. I forgot the reason of adding pointer-events: none here, I'm almost sure there was some reason but probably it doesn't make sense anymore after several iterations with schedules and visual components rearranging
maskin25
approved these changes
Apr 29, 2024
| <HorizontalGroup justify={justify}> | ||
| <span>Missing user</span> | ||
| <Tooltip | ||
| content={<>{`${userName || 'User'} `} is not found or doesn't have permission to participate in the rotation</>} |
There was a problem hiding this comment.
minor it could be just a string without using Fragment
…na/oncall into brojd/fix-user-not-found-in-shifts
brojd
added a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does - Don't show global notification if one of the rolling_users is a user that doesn't exist anymore (has been deleted) - In case user present in rolling_users has been either deleted or his/her role has been downgraded to Viewer, show such explicit info on UI   ## Which issue(s) this PR closes Closes #4251 <!-- *Note*: if you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR closes
Closes #4251
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.