Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule Issues #4428

Open
9 of 14 tasks
teodosii opened this issue May 31, 2024 · 5 comments
Open
9 of 14 tasks

Schedule Issues #4428

teodosii opened this issue May 31, 2024 · 5 comments
Labels
bug Something isn't working part:schedules

Comments

@teodosii
Copy link
Member

teodosii commented May 31, 2024 •
edited
Loading

What went wrong?

  • Rotation Form: Time is being changed each time the date gets changed
  • UI: Calendar shifts display once you click it (the one next to Period Selection)
  • Shifts starting with date in the past do not have preview on the UI
  • Changing the timezone doesn't reflect changes in the Rotation Modal
  • Rotations by 2 weeks still display only 1 week gap between rotations
  • Override Form: Changing the date changes the time as well incrementally
  • In existing OnCall schedule we see "Add Rotations to see users" and no users are being displayed on top unless you change period
  • A gap is being shown for weekly/monthly view at the end if you change the timezone
  • Preview schedule does not show the whole week view, it shows truncated instead (Fix display of schedule final in preview mode #4447)
  • Clicking the arrow on the schedules list does not show the preview, you need to click next to it instead
  • When requesting a shift swap the dialog is populated with the first shift times instead of the shift being swapped (Show correct swap request dates #4456)
  • UI bug: caret overlaps with text #4480
  • Schedule view current period shifts back to today whenever the timezone offset is being changed
  • Schedule shift swap is not set to 00:00 if the selected timezone differs from the browser's timezone #4688
@teodosii teodosii added the bug Something isn't working label May 31, 2024
@mderynck
Copy link
Contributor

When requesting a shift swap the dialog is populated with the first shift times instead of the shift being swapped

@teodosii teodosii self-assigned this Jun 3, 2024
@raphael-batte
Copy link

  • Part of the shift which continues from last week doesn't have visible username
    image
  • Calendar opens inline instead of overlay
    image

@raphael-batte
Copy link

@teodosii @matiasb It seems this is BE issue and now out of scope for FE
Rotations by 2 weeks still display only 1 week gap between rotations

@teodosii
Copy link
Member Author

teodosii commented Jun 3, 2024

@raphael-batte the issues listed here are not restricted to frontend only

@teodosii teodosii mentioned this issue Jun 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 4, 2024
@teodosii
Fix display of schedule final in preview mode (#4447)
2f1ffcf 
# What this PR does

- Fixes the display of preview schedule when you click on a row

Part of #4428
@iskhakov
Copy link
Contributor

iskhakov commented Jun 4, 2024

When requesting a shift swap the dialog is populated with the first shift times instead of the shift being swapped

Originally reported in https://raintank-corp.slack.com/archives/C0229FD3CE9/p1717106994906299

@teodosii teodosii mentioned this issue Jun 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 4, 2024
@teodosii
Show correct swap request dates (#4456)
038d78d 
# What this PR does

Part of #4428

Additionally it fixes
- NPE within `SchedulePersonal`
- changes the line-break to use `contrastText` instead of `main` (from
grafana theme)
This was referenced Jun 6, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this issue Jun 17, 2024
@teodosii
Make rotation start and rotation end take timezone into consideration (…
46629e2 
…#4481)

# What this PR does

- Fixes Rotation Start and Rotation End to take selected offset into
consideration
- Fixed issue where week/month period was being restored when the offset
was being changed (now it defaults to start of week, midnight, in
selected timezone offset)

Related to #4428
@teodosii teodosii mentioned this issue Jun 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 21, 2024
@teodosii
Tweaks to overrides (added draggable bounds, take timezone into consi…
16e98da 
…deration) (#4553)

# What this PR does

Part of #4428

## Which issue(s) this PR closes

Closes #4547
brojd pushed a commit that referenced this issue Sep 18, 2024
@teodosii
Fix display of schedule final in preview mode (#4447)
0bbe61f 
# What this PR does

- Fixes the display of preview schedule when you click on a row

Part of #4428
@teodosii teodosii removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working part:schedules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iskhakov @mderynck @teodosii @raphael-batte