Feat: Adding provenance publish config #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged but will not trigger a new release. To trigger a new release add the |
tolzhabayev
commented
Sep 24, 2024
| @@ -186,6 +186,9 @@ jobs: | |||
| NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }} | |||
| NX_BRANCH: ${{ github.event.number || github.ref_name }} | |||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
| permissions: | |||
There was a problem hiding this comment.
@jackw I've added this because I assume it will be required. fyi
There was a problem hiding this comment.
Looking at the docs we do need to set the id-token. However are we using this github token or the github-app-token further down?
There was a problem hiding this comment.
My assumption is that they are a bit different and it needs the specific id-token. I guess we will see once we run it :)
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Linking npm package builds better to source code and CI builds using sigstore.
More context in: https://docs.npmjs.com/generating-provenance-statements
I don't think we have to force publishing new versions just because of this change. I would rather just wait for regular releases to happen to those packages after this change is merged.