Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adding provenance publish config #1127

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Feat: Adding provenance publish config #1127

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
882e3d8
adding provenance publish config
tolzhabayev Sep 20, 2024
9afb09c
adding it token generation
tolzhabayev Sep 24, 2024
42aeeee
Merge branch 'main' into feat/add-sigstore-provenance
tolzhabayev Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ jobs:
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
NX_BRANCH: ${{ github.event.number || github.ref_name }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
permissions:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackw I've added this because I assume it will be required. fyi

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the docs we do need to set the id-token. However are we using this github token or the github-app-token further down?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption is that they are a bit different and it needs the specific id-token. I guess we will see once we run it :)

contents: read
id-token: write
steps:
- name: Generate token
id: generate_token
Expand Down
3 changes: 2 additions & 1 deletion packages/create-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
},
"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
"access": "public",
"provenance": true
},
"scripts": {
"clean": "rm -rf ./dist ./generated",
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"license": "Apache-2.0",
"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
"access": "public",
"provenance": true
},
"scripts": {
"clean": "rm -rf ./dist",
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-meta-extractor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
},
"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
"access": "public",
"provenance": true
},
"repository": {
"directory": "packages/plugin-meta-extractor",
Expand Down
3 changes: 2 additions & 1 deletion packages/sign-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
},
"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
"access": "public",
"provenance": true
},
"scripts": {
"clean": "rm -rf ./dist",
Expand Down
Loading