[v16] Fix Integration Button styles #50283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user could list integrations, and they could NOT create integrations, AND integrations existed, this would cause the disabled 'enroll new integration' button to be smashed to the left of the header (this is due to how its wrapped in an optional Hover Tooltip). This PR just adds some space-between flex property to the header to ensure the button stays on the right side. It also moves the HoverTooltip position to the bottom because it looks better
avatus
added
the
no-changelog
ravicious
approved these changes
Dec 16, 2024
ravicious
reviewed
Dec 16, 2024
| @@ -36,6 +36,7 @@ export function IntegrationsAddButton({ | |||
|
|
|||
| return ( | |||
| <HoverTooltip | |||
| position="bottom" | |||
There was a problem hiding this comment.
No <FeatureHeader justifyContent="space-between"> in v16?
There was a problem hiding this comment.
Oh, this doesn't need to go to v16. I forgot I fixed it in that backport due to other conflicts. I'll close this. The position prop doesn't exist in v16 (i guess its changes never got backported).
There was a problem hiding this comment.
@avatus FWIW, v16 doesn't have position="bottom".
There was a problem hiding this comment.
I'm going to ask around to understand why the recent changes to HoverTooltip didn't make it back to v16
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
approved these changes
Dec 16, 2024
auto-merge was automatically disabled
December 16, 2024 15:38
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #50258 to branch/v16