Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Fix Integration Button styles #50283

Closed
wants to merge 1 commit into from
Closed

[v16] Fix Integration Button styles #50283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/packages/teleport/src/Integrations/IntegrationsAddButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export function IntegrationsAddButton({

return (
<HoverTooltip
position="bottom"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No <FeatureHeader justifyContent="space-between"> in v16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into it now

Copy link
Contributor Author

@avatus avatus Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this doesn't need to go to v16. I forgot I fixed it in that backport due to other conflicts. I'll close this. The position prop doesn't exist in v16 (i guess its changes never got backported).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avatus FWIW, v16 doesn't have position="bottom".

teleport/web/packages/teleport/src/Integrations/IntegrationsAddButton.tsx

Lines 38 to 48 in 970f4f9

<HoverTooltip
tipContent={
canCreateIntegrations ? null : (
<MissingPermissionsTooltip
requiresAll={false}
missingPermissions={missingPermissions}
/>
)
}
>
<Button

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to ask around to understand why the recent changes to HoverTooltip didn't make it back to v16

tipContent={
canCreateIntegrations ? null : (
<MissingPermissionsTooltip
Expand Down
Loading