feat: another media custom controls type #566
Conversation
Kyzyl-ool
requested review from
gorgeousvlad and
yuberdysheva
as code owners
|
Preview is ready. |
Kyzyl-ool
force-pushed
the
feat/media-new-controls-type
branch
from
01deaf8 to
ca82669
Compare
Kyzyl-ool
force-pushed
the
feat/media-new-controls-type
branch
3 times, most recently
from
a7be789 to
6dad315
Compare
| @@ -69,12 +93,37 @@ $controlSize: 64px; | |||
| outline: none; | |||
| } | |||
| } | |||
|
|
|||
| &_with-uikit-play-pause-button { | |||
| width: 42px; | |||
| 0 2px 8px 0 var(--g-color-sfx-shadow-light); | ||
|
|
||
| &:focus { | ||
| outline: 2px solid var(--g-color-line-misc); |
There was a problem hiding this comment.
maybe create mixin for outlines if it would be the same for elements?
There was a problem hiding this comment.
yes, I will create this mixin here #576
| width: 24px; | ||
| &_type { | ||
| &_with-play-pause-button { | ||
| height: 24px; |
| width: 24px; | ||
| } | ||
| &_with-uikit-play-pause-button { | ||
| height: 16px; |
| @@ -87,6 +136,11 @@ $controlSize: 64px; | |||
| height: 24px; | |||
| width: 24px; | |||
| } | |||
| &_with-uikit-play-pause-button { | |||
| height: 16px; | |||
| mute?: MuteConfigProps; | ||
| elapsedTimePercent?: number; | ||
| type?: CustomControlsType; | ||
| isPaused?: boolean; | ||
| onPlayClick?: () => void; | ||
| shown: boolean; |
There was a problem hiding this comment.
make it non required pls
|
|
||
| const playPauseButton = useMemo(() => { | ||
| if (type !== CustomControlsType.WithPlayPauseButton) { | ||
| const icon = isPaused ? playIcon : pauseIcon; |
There was a problem hiding this comment.
seems like in the end we need only playPauseButton and muteButton, I propose to join all of this useMemo
There was a problem hiding this comment.
left as it is, but removed useMemo from the above variables
| wrapper: !currentHeight, | ||
| controls, | ||
| 'background-shadow-rendered': | ||
| !backgroundShadowHidden && |
There was a problem hiding this comment.
it would be better to use flag showBackgroundShadow or just backgroundShadow
same for muteButtonHidden
| { | ||
| wrapper: !currentHeight, | ||
| controls, | ||
| 'background-shadow-rendered': |
There was a problem hiding this comment.
what is the meaning of 'background-shadow-rendered' modifier?
There was a problem hiding this comment.
removed, as it is not needed anymore
…for the second one
Kyzyl-ool
force-pushed
the
feat/media-new-controls-type
branch
from
6dad315 to
77cecfb
Compare
| @@ -3,18 +3,44 @@ | |||
|
|
|||
| $block: '.#{$ns}CustomBarControls'; | |||
| $controlSize: 64px; | |||
| // custom controls sizes | |||
| $with-uikit-play-pause-control-size: 42px; | |||
There was a problem hiding this comment.
could you please turn it to camelCase?
positioning,ratioandmuteButtonHiddenprops for video