feat: another media custom controls type #566
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,18 +3,44 @@ | |
|
|
||
| $block: '.#{$ns}CustomBarControls'; | ||
| $controlSize: 64px; | ||
| // custom controls sizes | ||
| $with-uikit-play-pause-control-size: 42px; | ||
| $with-uikit-play-pause-control-icon-size: 16px; | ||
| $with-mute-control-height: 22px; | ||
| $with-mute-control-width: 32px; | ||
| // --- | ||
|
|
||
| #{$block} { | ||
| &__wrapper { | ||
| position: absolute; | ||
| bottom: 0; | ||
| opacity: 0; | ||
| transition: opacity $animationDuration ease 3s; | ||
|
|
||
| &_shown { | ||
| opacity: 1; | ||
| transition: opacity 0s ease 0s; | ||
| } | ||
|
|
||
| &_type { | ||
| &_with-uikit-play-pause-button { | ||
| gap: $indentXXXS; | ||
| padding: $indentXXXS; | ||
| } | ||
| } | ||
|
|
||
| &_positioning { | ||
| &_left, | ||
| &_right, | ||
| &_center { | ||
| display: flex; | ||
| width: 100%; | ||
| } | ||
| &_right { | ||
| flex-direction: row-reverse; | ||
| } | ||
| &_center { | ||
| justify-content: center; | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -25,25 +51,6 @@ $controlSize: 64px; | |
| cursor: pointer; | ||
|
|
||
| &_type { | ||
| &_with-mute-button { | ||
| border-radius: 50%; | ||
| display: flex; | ||
|
|
@@ -55,7 +62,7 @@ $controlSize: 64px; | |
| height: $controlSize; | ||
| background: var(--g-color-base-background); | ||
| transition: background-color $animationDuration; | ||
| margin: $indentXXS; | ||
|
|
||
| &:hover, | ||
| &:focus { | ||
|
|
@@ -69,23 +76,44 @@ $controlSize: 64px; | |
| outline: none; | ||
| } | ||
| } | ||
|
|
||
| &_with-uikit-play-pause-button { | ||
| width: $with-uikit-play-pause-control-size; | ||
| height: $with-uikit-play-pause-control-size; | ||
| border-radius: 50%; | ||
| background: var(--g-color-base-background); | ||
| @include shadow(); | ||
|
|
||
| &:focus { | ||
| outline: 2px solid var(--g-color-line-misc); | ||
|
There was a problem hiding this comment. maybe create mixin for outlines if it would be the same for elements? There was a problem hiding this comment. yes, I will create this mixin here #576 |
||
| } | ||
| &:focus:not(:focus-visible) { | ||
| outline: none; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| &__play-icon { | ||
| &_type { | ||
| &_with-uikit-play-pause-button { | ||
| height: $with-uikit-play-pause-control-icon-size; | ||
| width: $with-uikit-play-pause-control-icon-size; | ||
| color: var(--g-color-base-neutral-heavy); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| &__mute-icon { | ||
| &_type { | ||
| &_with-mute-button { | ||
| height: $with-mute-control-height; | ||
| width: $with-mute-control-width; | ||
| } | ||
| &_with-uikit-play-pause-button { | ||
| height: $with-uikit-play-pause-control-icon-size; | ||
| width: $with-uikit-play-pause-control-icon-size; | ||
| color: var(--g-color-base-neutral-heavy); | ||
| } | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please turn it to camelCase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done