Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GSA description at the about page #3793

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

bjoernricks
Copy link
Contributor

What

Adjust GSA description at the about page

Why

Try to improve the about page for using our current naming an terms.

References

GEA-72

@bjoernricks bjoernricks requested a review from a team as a code owner June 30, 2023 11:59
@github-actions
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the German translation for the new text?

@swaterkamp
Copy link
Member

Please do not run the translation scripts. If you HAVE to add translations, you need to add them manually and correctly ordered to the json

Try to improve the about page for using our current naming an terms.
@bjoernricks
Copy link
Contributor Author

I've added German translations for the changes of the about page.

@bjoernricks bjoernricks enabled auto-merge (rebase) July 24, 2023 12:46
@bjoernricks bjoernricks marked this pull request as draft July 24, 2023 12:50
auto-merge was automatically disabled July 24, 2023 12:50

Pull request was converted to draft

@bjoernricks bjoernricks marked this pull request as ready for review July 24, 2023 12:52
@bjoernricks bjoernricks enabled auto-merge (rebase) July 24, 2023 12:53
@bjoernricks bjoernricks merged commit cd8c6f5 into main Jul 24, 2023
8 checks passed
@bjoernricks bjoernricks deleted the improve-about-page branch July 24, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants