Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct nvt column in OVERRIDE_ITERATOR_COLUMNS #2173

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

mattmundell
Copy link
Contributor

What

In OVERRIDE_ITERATOR_COLUMNS change the name of the NVT filter column from name to nvt.

Why

The column corresponds to the filter keyword "nvt". There is already a "name" column further up (column 3).

This solves an assertion failure, for example:

o m m '<get_overrides filter="nvt=Count.cgi"/>'

results in

gvmd: /home/matt/fresh/main/gvmd/src/manage_sql.c:3491: filter_clause: Assertion `column' failed.

on gvmd stderr.

References

I introduced this error in 2015 in ec97206, see line 26947.

@mattmundell mattmundell requested a review from a team as a code owner April 18, 2024 14:03
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bjoernricks bjoernricks enabled auto-merge (rebase) April 22, 2024 06:59
@bjoernricks bjoernricks merged commit 582c613 into main Apr 22, 2024
9 checks passed
@bjoernricks bjoernricks deleted the get-overrides-filter-nvt branch April 22, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants