Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Support Existing Table Column Information #231

Merged
merged 9 commits into from
Jan 16, 2024
Merged

Conversation

ruxuez
Copy link
Contributor

@ruxuez ruxuez commented Jan 8, 2024

So far, we don't have any information about the DataFrame's
columns and their types. This patch supports retrieving column
information of an existing table in the database.
Moreover, adds a table check when creating a DataFrame from table,
so that the user can catch the name error early.

@ruxuez ruxuez marked this pull request as draft January 8, 2024 16:38
@xuebinsu
Copy link
Contributor

xuebinsu commented Jan 9, 2024

This is a good start! Let's try not to break the API at the beginning so that some of the code can enter version 1.2.0 .

@ruxuez ruxuez changed the title Support Column Inference Support Existing Table Column Information Jan 9, 2024
@ruxuez ruxuez marked this pull request as ready for review January 9, 2024 09:40
@ruxuez ruxuez requested a review from xuebinsu January 9, 2024 09:44
@xuebinsu
Copy link
Contributor

How about exposing this functionality as DataFrame.describe(), so that this can be done lazily, i.e. only when user needs the info?

@ruxuez
Copy link
Contributor Author

ruxuez commented Jan 10, 2024

How about exposing this functionality as DataFrame.describe(), so that this can be done lazily, i.e. only when user needs the info?

Do you mean for now only do it lazily?

@xuebinsu
Copy link
Contributor

How about exposing this functionality as DataFrame.describe(), so that this can be done lazily, i.e. only when user needs the info?

Do you mean for now only do it lazily?

Yes, when user asks for it.

tests/test_dataframe.py Outdated Show resolved Hide resolved
@ruxuez ruxuez requested a review from xuebinsu January 11, 2024 15:01
@ruxuez ruxuez merged commit a826c67 into main Jan 16, 2024
6 checks passed
@ruxuez ruxuez deleted the feat_column_inference branch January 16, 2024 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants