Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Support Existing Table Column Information #231

Merged
merged 9 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion greenplumpython/dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ def save_as(
""",
has_results=False,
)
return DataFrame.from_table(table_name, self._db, schema=schema)
return DataFrame.from_table(table_name, self._db, schema=schema if not temp else "pg_temp")

def create_index(
self,
Expand Down Expand Up @@ -1264,3 +1264,25 @@ def from_files(cls, files: list[str], parser: "NormalFunction", db: Database) ->
raise NotImplementedError(
"Please import greenplumpython.experimental.file to load the implementation."
)

def describe(self) -> dict[str, str]:
"""
Return a dictionary summarising the column information of the dataframe, conditional on the table existing in the database.

Returns:
Dictionary containing the column names and types.

"""
assert self._qualified_table_name is not None, f"Dataframe is not saved in database."
columns_query = f"""
SELECT attname AS column_name, atttypid::regtype AS data_type
FROM pg_attribute
WHERE attrelid = '{self._qualified_table_name}'::regclass and attnum > 0;
"""
assert self._db is not None
columns_inf_result = list(self._db._execute(columns_query, has_results=True)) # type: ignore reportUnknownVariableType
assert columns_inf_result, f"Table {self._qualified_table_name} does not exists."
columns_list: dict[str, str] = {
d["column_name"]: d["data_type"] for d in columns_inf_result # type: ignore reportUnknownVariableType
} # type: ignore reportUnknownVariableType
return columns_list
17 changes: 17 additions & 0 deletions tests/test_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -506,3 +506,20 @@ def test_const_non_ascii(db: gp.Database):
df = db.create_dataframe(columns={"Ø": ["Ø"]})
for row in df[["Ø"]]:
assert row["Ø"] == "Ø"


def test_table_describe(db: gp.Database):
df = db.create_dataframe(table_name="pg_class")
result = df.describe()
assert len(result) == 33
xuebinsu marked this conversation as resolved.
Show resolved Hide resolved
df_not_exist = db.create_dataframe(table_name="not_exist_table")
with pytest.raises(Exception) as exc_info:
df_not_exist.describe()
assert 'relation "not_exist_table" does not exist' in str(exc_info.value)


def test_dataframe_describe(db: gp.Database):
df = db.create_dataframe(table_name="pg_class")[["relname", "relnamespace"]]
with pytest.raises(Exception) as exc_info:
df.describe()
assert "Dataframe is not saved in database" in str(exc_info.value)
Loading