Show language selector! #360
Conversation
This allows the user to show the documentation in French for now and in other languages in the future.
✅ Deploy Preview for grist-help-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hmm, once this happens, the selector will show on support.getgrist.com. The French translation is so bare, including on the default/front page, that it might be mostly disappointing for users.
If you don't care about support.getgrist.com, we could maybe add a flag so the selector doesn't show their yet. But if getting it to show there is the point, I can check in with Grist Labs support people to see how they feel about this.
The French translation is already available at https://support.getgrist.com/fr/
|
I expected that it would encourage to help translating the website, if we advertise it as needing some work from the community. That being said, probably in such a case we should either make it explicit that it's still in beta phase, or continue translating on our side before making it public. I don't mind waiting until we have more content in French (so opt for the second option), and until then close or make this PR as "WIP". |
|
How about if this message were rewritten a bit for the case where most translations are missing.
Like "We're just getting started translating this language, sorry! We show partially translated languages so translators can track progress. This page isn't translated yet. But you can help..." maybe? |
|
@paulfitz That's interesting. I would need to be sure of the purpose(s) you have in mind for the message so I can enhance relevantly (also I may need to tweak a bit the code depending on your answer):
|
|
I like the option of having the "work in progress, help needed" warning message @paulfitz ! Sorry for falling behind on translation we'll get to it this summer ! |
|
I propose this message based on your suggestion:
It's rendered like below in French:
|
fflorent
force-pushed
the
show-language-selector
branch
from
0b2bc62
to
dc2f4fd
Compare
There was a problem hiding this comment.
Thank you, the revised language works well! Checked in with rest of support team, they are excited for the French translation to make progress. in any way. One "nice to have" that came up would be to match style on the language dropdown with the style used in the main application. But for the moment a less polished and less consistent look may actually set expectations more appropriately.
Leaving it to you to land at your convenience @fflorent.
|
@paulfitz Do you mean like this? (The font size is set like for the other elements on the top) |
|
I pushed an update of the code in a separate commit. Your feedback is welcome |
|
That is a welcome tweak. But what we hand in our mind with this kind of dropdown used in the Grist app:
This PR is good to land in my opinion, and I wouldn't actually want to hold it for a discussion about a fancier dropdown. We could revisit when there's at least one complete translation :-) |
|
Thanks for the clarification! I merge as suggested, we'll work on that in a follow-up |
This allows the user to show the documentation in French for now and in other languages in the future.