cloudrun: GKE client to cloudrun server test #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
framework/test_app/runners/cloud_run/cloud_run_xds_server_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_server_runner.py
Outdated
Show resolved
Hide resolved
sergiitk
reviewed
Apr 15, 2025
sergiitk
reviewed
Apr 15, 2025
…ani/psm-interop into eshita_gke_cloudrun
Member
Author
|
Include this in your PR: |
eshitachandwani
commented
Apr 16, 2025
sergiitk
reviewed
Apr 17, 2025
framework/infrastructure/mesh_resource_manager/cloud_run_mesh_manager.py
Outdated
Show resolved
Hide resolved
framework/infrastructure/mesh_resource_manager/cloud_run_mesh_manager.py
Outdated
Show resolved
Hide resolved
framework/infrastructure/mesh_resource_manager/cloud_run_mesh_manager.py
Outdated
Show resolved
Hide resolved
sergiitk
force-pushed
the
eshita_gke_cloudrun
branch
from
08d4831 to
5128b98
Compare
sergiitk
reviewed
Apr 18, 2025
framework/test_app/runners/cloud_run/cloud_run_xds_server_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_server_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_server_runner.py
Outdated
Show resolved
Hide resolved
sergiitk
reviewed
Apr 22, 2025
sergiitk
approved these changes
Apr 22, 2025
Member
sergiitk
left a comment
sergiitk
left a comment
There was a problem hiding this comment.
You missed a few things, but overall LGTM.
One of the things is looks like these fields are gone from backend_service_add_cloudrun_backends now - I don't think this was intentional
"balancingMode": balancing_mode,
"capacityScaler": capacity_scaler,
Also please remember to run the tests one more time before merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the case where the client is in GKE and the server is running in cloudrun. Verifies that 100 RPCs reach the server correctly and return with the correct response.