WIP: Add testing to modules #384
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbjacobson
approved these changes
Mar 16, 2021
|
@tompretty shall we get this merged? It's a good starting point for rendering tests |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add testing to the modules (epics & banners). We want, for a start, a basic level of "smoke testing" to ensure changes that we make don't leave the components unable to render. As a first pass, I've added some a test with jest + react-testing-library to test if a component renders. However, this does not work (for catching an issue with accidently using server only code). Due to the environment the tests run in they still have access to e.g
process.env.stage, which should only be used on the server. I think if we really want to test the components are working, we might need to run them in a production like environment: running dcr -> requesting and epic -> asserting it has rendered.