[PE1-1809] Support Function Associations for ingress-based behaviors #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Caparelli <[email protected]>
Signed-off-by: Lucas Caparelli <[email protected]>
Signed-off-by: Lucas Caparelli <[email protected]>
|
Sorry for the longest PR in history @caiofralmeida, next ones should be much shorter as they will share much of the logic introduced here 🙇 Each commit is more-or-less digestible and local, so I'd suggest checking one at a time. |
::warning file=internal/k8s/function_association.go,line=232,col=2:: if-return: redundant if ...; err != nil check, just return error instead. (revive) ::error file=internal/cloudfront/origin.go,line=76,col=2:: field `viewerFnARN` is unused (unused) ::error file=internal/k8s/ingress.go,line=122,col=2:: S1011: should replace loop with `paths = append(paths, sp.paths[ing]...)` (gosimple) Signed-off-by: Lucas Caparelli <[email protected]>
Signed-off-by: Lucas Caparelli <[email protected]>
This was referenced Oct 10, 2023
Signed-off-by: Lucas Caparelli <[email protected]>
Signed-off-by: Lucas Caparelli <[email protected]>
caiofralmeida
approved these changes
Oct 17, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO in upcoming PRs:
Motivation and Context
This allows users to specify both Cloudfront Functions and Lambda@Edge Functions that should be associated with behaviors present in the distribution.
How has this been tested?
Created, updated and deleted functions from a Distribution based on multiple Ingresses.
Checklist