Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE1-1809] Support Function Associations for ingress-based behaviors #105

Merged
merged 7 commits into from
Oct 17, 2023
Merged

[PE1-1809] Support Function Associations for ingress-based behaviors #105

merged 7 commits into from
Oct 17, 2023

Commits on Oct 10, 2023

  1. feat(k8s): support function-associations annotation 

    Signed-off-by: Lucas Caparelli <[email protected]>
    @LCaparelli
    LCaparelli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c841337 View commit details
    Browse the repository at this point in the history

  2. feat(cloudfront): support function-associations in domain objects 

    Signed-off-by: Lucas Caparelli <[email protected]>
    @LCaparelli
    LCaparelli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    24c0fd5 View commit details
    Browse the repository at this point in the history

  3. feat(cloudfront): support function-associations in persistence layer 

    Signed-off-by: Lucas Caparelli <[email protected]>
    @LCaparelli
    LCaparelli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    57d5af3 View commit details
    Browse the repository at this point in the history

  4. refac: fix linter warnings/errors 

    ::warning
  file=internal/k8s/function_association.go,line=232,col=2::
  if-return: redundant if ...; err != nil check,
  just return error instead. (revive)
::error file=internal/cloudfront/origin.go,line=76,col=2::
  field `viewerFnARN` is unused (unused)
::error file=internal/k8s/ingress.go,line=122,col=2::
  S1011: should replace loop with
  `paths = append(paths, sp.paths[ing]...)` (gosimple)

Signed-off-by: Lucas Caparelli <[email protected]>
    @LCaparelli
    LCaparelli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    074821f View commit details
    Browse the repository at this point in the history

  5. feat(k8s): deprecate cf.viewer-function-arn for cf.function-associations 

    Signed-off-by: Lucas Caparelli <[email protected]>
    @LCaparelli
    LCaparelli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9ca9d5c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. refac(cloudfront): extract methods for each FA 

    Signed-off-by: Lucas Caparelli <[email protected]>
    @LCaparelli
    LCaparelli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    e2251e6 View commit details
    Browse the repository at this point in the history

  2. refac(k8s): log invalid FAs as errors 

    Signed-off-by: Lucas Caparelli <[email protected]>
    @LCaparelli
    LCaparelli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ce1b399 View commit details
    Browse the repository at this point in the history