Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values first approach #20

Closed
wants to merge 5 commits into from
Closed

Values first approach #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82d276d
Values first approach
cperezln Dec 21, 2023
731d464
Test changed to check pd.values against implemented values. Values op…
cperezln Dec 21, 2023
db79521
Changed to property (as defined in pandas docs). documentation written
cperezln Dec 21, 2023
213f65e
Changed values to property (as defined in pandas docs). values docume…
cperezln Dec 21, 2023
7b15166
Undone Notebook metadata changes
cperezln Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/pykx/pandas_api/pandas_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,11 @@ def sum(self, axis=0, skipna=True, numeric_only=False, min_count=0):
min_count
), cols)

@api_return
def values(self, skipna = True, numeric_only = False):
tab = self
return q('{[table] flip value flip table}', tab)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this is more efficient:

return q("value peach", tab)


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you redo this change?

def agg(self, func, axis=0, *args, **kwargs): # noqa: C901
if 'KeyedTable' in str(type(self)):
raise NotImplementedError("'agg' method not presently supported for KeyedTable")
Expand Down
8 changes: 8 additions & 0 deletions tests/test_pandas_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2029,3 +2029,11 @@ def test_keyed_loc_fixes(q):
mkt[['k1', 'y']]
with pytest.raises(KeyError):
mkt['k1']

def test_values(q):
col1 = q('10?100')
col2 = q('10?`a`b`c`d')
col3 = q('10?`x`y`z`1`2`3')
matrix = q('{[r1; r2; r3] flip enlist[r1; r2; r3]}', col1, col2, col3)
tab = q('{[price; sym; id] ([]p: price; s: sym; i: id)}', col1, col2, col3)
assert tab.values().py() == matrix.py()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do the test the way I told you before:

q_table = tab
pandas_table = tab.pd()
q("~", kx.toq(pandas_table.values), q_table.values())