Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kurt and sem functions #32

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

nipsn
Copy link

@nipsn nipsn commented Feb 8, 2024

Adds both kurt and sem functions as found on feature/pandas-api-2nd-block but patched to meet the new code style without fstrings.

@nipsn nipsn requested a review from neutropolis February 8, 2024 12:09
@nipsn nipsn self-assigned this Feb 8, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python tests labels Feb 8, 2024
Copy link
Member

@neutropolis neutropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested several minor changes. @nipsn can you take a look at them? Thanks!

src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
src/pykx/pandas_api/pandas_meta.py Outdated Show resolved Hide resolved
docs/user-guide/advanced/Pandas_API.ipynb Outdated Show resolved Hide resolved
@nipsn nipsn requested a review from neutropolis February 9, 2024 13:28
Copy link
Member

@neutropolis neutropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nipsn nipsn merged commit bb1549a into feature/pandas-api-2nd-block-extra Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants