feat(RELEASE-951): integrate Checkton for linting #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanconroy2021
commented
Jun 12, 2024
seanconroy2021
changed the title
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
seanconroy2021
force-pushed
the
feat(951)-shellChecker
branch
from
5b054ea
to
7d30ffd
Compare
theflockers
reviewed
Jul 5, 2024
seanconroy2021
force-pushed
the
feat(951)-shellChecker
branch
3 times, most recently
from
847e0ce
to
cf9180b
Compare
seanconroy2021
changed the title
seanconroy2021
force-pushed
the
feat(951)-shellChecker
branch
2 times, most recently
from
49600eb
to
43d0ec4
Compare
seanconroy2021
force-pushed
the
feat(951)-shellChecker
branch
from
43d0ec4
to
bc2e9af
Compare
mmalina
reviewed
Jul 9, 2024
seanconroy2021
force-pushed
the
feat(951)-shellChecker
branch
2 times, most recently
from
1fec752
to
49d3a7c
Compare
mmalina
approved these changes
Jul 11, 2024
seanconroy2021
force-pushed
the
feat(951)-shellChecker
branch
from
49d3a7c
to
8b0497f
Compare
This updats the linting workflow by adding Checkton. Checkton will review code for linting errors. Changes: * Added a step to the workflow to run Checkton. * Configured Checkton to upload the SARIF report. This implementation is based on: konflux-ci/build-definitions#1051 Signed-off-by: Sean Conroy <[email protected]>
seanconroy2021
force-pushed
the
feat(951)-shellChecker
branch
from
8b0497f
to
a0621d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the linting workflow by adding Checkton. Checkton will review the code for linting errors.
Changes: