Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize yielding to fix jank #964

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Synchronize yielding to fix jank #964

merged 2 commits into from
Mar 12, 2025

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Mar 11, 2025

explicit synchronization is the way to go

  • should the flickering yield sign problem
  • won't avoid problems where clients try to yield/stop yielding but aren't in sync (would take more refactoring)
  • should also fix some problems with the yield countdown not restarting maybe

@toberge toberge requested a review from Fueredoriku March 11, 2025 21:48
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, great to have this fixed!! 👍
We should probably test this a bit thoroughly together before we deploy this (but the behaviour can't be much worse than it already is lol)

@toberge toberge merged commit ed87102 into dev Mar 12, 2025
3 checks passed
@toberge toberge deleted the fix/yield-jank branch March 12, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

None yet

2 participants