-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused scripts. #6243
Remove unused scripts. #6243
Conversation
Removed this file as it's scripts were obviated by a previous PR: hackforla#5978
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Review ETA: 2/7/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @JackCasica - you are attempting to merge your commit into the correct base branch, are linking the corresponding issue with the proper PR formatting, and your change is applicable! Just a couple of small things to note:
- Include the issue number in your branch name.
- When no visual changes are made, please explain e.g. "Deleted unused script only. No visual changes to the website."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there , great work there all the work assigned to you in the issue is done correctly
- the to/from branch looks good
- the deletion specified is done correctly
- the issue linked is correct too
PR approved.......
Hi @JackCasica and @tesiahwang! @tesiahwang, great non-functional requests! @JackCasica, I am going to go ahead and merge the code this time as it is correct and working, but if you could please update the original comment to include the reasoning why the screenshots were not included. In addition, please update the title to include the file names of the files that were removed. In the future, please do include the issue number in the branch name. Please don't hesitate to reach out if you need any help or clarifications. Great work and thank you for taking the time to contribute! |
Fixes #6200
What changes did you make?
current-projects-check.js
file fromassets/js
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)