Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused scripts. #6243

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

JackCasica
Copy link
Member

@JackCasica JackCasica commented Feb 6, 2024

Fixes #6200

What changes did you make?

  • Deleted current-projects-check.js file from assets/js

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • Deleted unused script only. No visual changes to the website.

Removed this file as it's scripts were obviated by a previous PR: hackforla#5978
Copy link

github-actions bot commented Feb 6, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b JackCasica-remove-unused-file gh-pages
git pull https://github.com/JackCasica/website.git remove-unused-file

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/JackCasica/website/blob/remove-unused-file/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Feb 6, 2024
@tesiahwang tesiahwang self-requested a review February 7, 2024 04:56
@tesiahwang
Copy link
Member

tesiahwang commented Feb 7, 2024

Review ETA: 2/7/2024
Availability: flexible

Copy link
Member

@tesiahwang tesiahwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @JackCasica - you are attempting to merge your commit into the correct base branch, are linking the corresponding issue with the proper PR formatting, and your change is applicable! Just a couple of small things to note:

  • Include the issue number in your branch name.
  • When no visual changes are made, please explain e.g. "Deleted unused script only. No visual changes to the website."

@freaky4wrld freaky4wrld self-requested a review February 7, 2024 07:52
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there , great work there all the work assigned to you in the issue is done correctly

  • the to/from branch looks good
  • the deletion specified is done correctly
  • the issue linked is correct too
    PR approved.......

@LRenDO
Copy link
Member

LRenDO commented Feb 7, 2024

Hi @JackCasica and @tesiahwang!

@tesiahwang, great non-functional requests! @JackCasica, I am going to go ahead and merge the code this time as it is correct and working, but if you could please update the original comment to include the reasoning why the screenshots were not included. In addition, please update the title to include the file names of the files that were removed. In the future, please do include the issue number in the branch name.

Please don't hesitate to reach out if you need any help or clarifications.

Great work and thank you for taking the time to contribute!

@LRenDO LRenDO merged commit 57b0c8f into hackforla:gh-pages Feb 7, 2024
10 checks passed
@JackCasica JackCasica deleted the remove-unused-file branch February 8, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removed unused file current-projects.js
4 participants