Sync HAFS submodules with their corresponding authoritative branches #86
Conversation
…lop 07/16/2021. *The HAFS related CCPP suites were also renamed.
Remove the ncld namelist option from input.nml files.
…16' into feature/hafs_sync_20210723
… forecast modulefile.
…, fhmaxhf, fhouthf) *Remove obsolete config options (total_member, PE_MEMBER01, cpl) from model_configure *Add the output_fh config option in model_configure *Remove the unneeded empty data_table file *exhafs_forecast.sh was modified accordingly for the above changes
…gure.tmp and exhafs_forecast.sh accordingly.
…guration. This is to bypass the failed global-nesting forecast failure, for which the root cause is still being investigated.
BinLiu-NOAA
requested review from
evankalina,
KathrynNewman and
ZhanZhang-NOAA
as code owners
BinLiu-NOAA
requested review from
BijuThomas-NOAA,
LinZhu-NOAA,
mrinalbiswas and
panll
|
@ghassan-alaka and @AndrewHazelton, I have synced to point to the latest support/HAFS branch of GPLOT. Let me know if there are any hrdgraphics related changes you want to add to this PR at the application/workflow level. |
|
@BinLiu-NOAA, yes there are a few changes that I would like to make in the HAFS scripts/ and jobs/ directories for hrdgraphics. All changes are in my HAFS branch (HAFS/hotfix-hrdgraphics). How would you like to merge those changes into the HAFS/develop branch? The most logical step seems like we should merge the hotfix-hrdgraphics branch into feature/hafs_sync_202107 and have it be a part of this current PR. What do you think? Also, I noticed that you've updated hafs_graphics.fd/hrd_gplot as of 07/27/2021. I just merged another series of updates that would probably be useful for anyone running the hrdgraphics task. Could you make sure these latest changes get into this PR? Here is a link to the GPLOT/support/HAFS PR: hafs-community/GPLOT#8. |
|
Thanks, @ghassan-alaka! Yes, I have just synced this feature/hafs_sync_202107 branch with your hotfix-hrdgraphics branch, so that the application/workflow level get the related hrdgraphics needed changes. In the meantime, I also updated the hafs_graphics.fd/hrd_gplot submodule to point the latest commit of the support/HAFS branch as of today (08/10/2021). I have added you as a reviewer for this PR. Please help to check this PR now has all the hrd graphics related changes you want to go back HAFS develop branch. Thanks! |
|
The regression tests on Orion passed. @BinLiu-NOAA @evankalina However, the compiling of hycom_utils failed on Hera, here are the error messages: /scratch2/BMC/fv3lam/lpan/test/08102021/hafs_sync_202107/sorc/logs/build_hycom_utils.log. |
|
@BinLiu-NOAA, The RT tests with feature/hafs_sync_202107 branch is successful on WCOSS(Cray) |
|
@BinLiu-NOAA The regression tests completed successfully on WCOSS-Dell. |
|
Regression tests completed successfully on Hera. @BinLiu-NOAA @evankalina |
danrosen25
dismissed stale reviews from evankalina, panll, BijuThomas-NOAA, and LinZhu-NOAA
via
a349a24
|
Thanks for conducting the regression tests and fix the issues! I think this PR is ready to merge. Need at another review approval though. Thanks! |
Description of changes
Sync HAFS submodules with their corresponding authoritative branches:
Besides application level changes were made accordingly with the updated submodules.
Issues addressed
This PR addresses issue #80.
Notes:
Tests conducted
What testing has been conducted on the PR thus far? Describe the nature of any scientific or technical tests, including relevant details about the configuration(s) (e.g., cold versus warm start, number of cycles, forecast length, whether data assimilation was performed, etc). What platform(s) were used for testing?
HAFS application level regression tests went through on Orion. The two-cycle HAFS ENSDA test also ran through on Orion.
Application-level regression test status
Running the HAFS application-level regression tests is currently performed by code reviewers after the developer creates the initial PR. As regression tests are conducted, the testers should use the checklist below to indicate successful regression tests. You may add other tests as needed. If a test fails, do not check the box. Instead, describe the failure in the PR comments, noting the platform where the test failed.
Again, appreciate it if you could help to run the regression tests as you helped previously!
@evankalina, @panll, @mrinalbiswas (Hera and Orion)
@JunghoonShin-NOAA (Jet, we probably will skip Jet since it is occupied by the HFIP real-time parallel experiments under reservation)
@LinZhu-NOAA (wcoss_dell_p3)
@BijuThomas-NOAA (wcoss_cray)