Fix build with Postgres 166 libpq-dev in debian. #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build passes locally with a released version of Postgres 16.0 and still builds with previous version. Still missing CI changes to pass all the test suite with PGVERSION=16. See #1005.
The internal organisation of the header files in Postgres 16 changed in a
way that we can't poke into libpq-int.h anymore, when building on debian,
because of the way the include/common bits are including in libpq (16)
rather than in the postgresql-server-dev-16 parts.
That said, we can stop looking into the internal details of libpq:
- connection->last_sqlstate allowed an optimisation to conclude that the
connection is okay early in the polling.
- connection->auth_req_received allowed to discard authentication error as
connectivity problems, but we decided in the past that we need to deploy
a monitor user on the Postgres nodes anyway, to avoid flooding Postgres
logs with authentication errors.
Allow building for Postgres 16 and Citus 12.1.0.
dimitri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build passes locally with a released version of Postgres 16.0 and still builds with previous version. Still missing CI changes to pass all the test suite with PGVERSION=16.
Fixes #1005.