Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Postgres 166 libpq-dev in debian. #1006

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Commits on Sep 20, 2023

  1. Add support for Postgres 16.

    Build passes locally with a released version of Postgres 16.0 and still
    builds with previous version. Still missing CI changes to pass all the test
    suite with PGVERSION=16.
    
    See #1005.
    dimitri committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3e69d8d View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Configuration menu
    Copy the full SHA
    6b9cc84 View commit details
    Browse the repository at this point in the history
  2. Allow code to build with newer Postgres releases.

    The internal organisation of the header files in Postgres 16 changed in a
    way that we can't poke into libpq-int.h anymore, when building on debian,
    because of the way the include/common bits are including in libpq (16)
    rather than in the postgresql-server-dev-16 parts.
    
    That said, we can stop looking into the internal details of libpq:
    
      - connection->last_sqlstate allowed an optimisation to conclude that the
        connection is okay early in the polling.
    
      - connection->auth_req_received allowed to discard authentication error as
        connectivity problems, but we decided in the past that we need to deploy
    	a monitor user on the Postgres nodes anyway, to avoid flooding Postgres
    	logs with authentication errors.
    dimitri committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    31f6ea3 View commit details
    Browse the repository at this point in the history
  3. Review Citus/Postgres compat matrix.

    Allow building for Postgres 16 and Citus 12.1.0.
    dimitri committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    ed3858b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    268e6fd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    02c4a4a View commit details
    Browse the repository at this point in the history
  6. Fix previous commit.

    dimitri committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d6a22bd View commit details
    Browse the repository at this point in the history