-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View change: Support for checking if validators belongs to the same key. #4802
base: dev
Are you sure you want to change the base?
Conversation
@Frozen can you help rebase and fix conflict here. |
ba7d2a5
to
37e81e1
Compare
@Frozen can you rebase this one with the latest dev ? |
@Frozen I tested killing the external validator node to test view change in two scenarios: make multi-bls-key and make-multi-bls-key-multi-extl-node (#4819) Both fails to even recover from view change. Networks is basically down when view change kick off when the external leader fails to propose for the test cc @mur-me |
Support for checking if validators belongs to the same key.
Leader Rotation based on
getLeaderPubKey
which is different for each iteration, while the view change it stays the same all time, that's why it requires additional actions for leader selection.Based on feature
IsLeaderRotationV2Epoch
applies methodgetNextLeaderKeySkipSameAddress
.