Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: form validation bugs #64

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

honuuk
Copy link
Contributor

@honuuk honuuk commented Jan 19, 2025

fix: #55 #56 #59

The following changes were made. There are also some parts where the code was slightly refined.
Please check it out.

Changes

  • re-initialize useForm defaultValues when formFields change
  • fix input validation bug (e.g., allowing empty text in required inputs)
  • fix incorrect form default values

Copy link

vercel bot commented Jan 19, 2025

@honuuk is attempting to deploy a commit to the hasanharman's projects Team on Vercel.

A member of the Team first needs to authorize it.

@honuuk
Copy link
Contributor Author

honuuk commented Feb 13, 2025

@hasanharman
Hi, Hasan. Could you please review my PR when you have a moment?

I've noticed that the project hasn't been updated recently. I understand you might be busy.
Given the current situation, would you consider adding me as a maintainer for this project? I'd be happy to help keep things moving forward.

Also, if you have a preferred communication tool, please let me know. It would be great to have a direct line of contact for any project-related discussions.

Copy link
Owner

@hasanharman hasanharman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work thank you!

@hasanharman hasanharman merged commit 145c2e6 into hasanharman:main Feb 21, 2025
1 check failed
@hasanharman
Copy link
Owner

I took a break and come back yet! That is a great contribution thanks for your help and great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Checkbox required is not working
2 participants