Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: form validation bugs #64

Merged
merged 6 commits into from
Feb 21, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions components/ui/signature-input.tsx
Original file line number Diff line number Diff line change
@@ -48,7 +48,9 @@ export default function SignatureInput({
const isDarkClass = document.documentElement.classList.contains('dark')
const isLightClass = document.documentElement.classList.contains('light')

const systemPrefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches
const systemPrefersDark = window.matchMedia(
'(prefers-color-scheme: dark)',
).matches

const isDarkMode = isDarkClass || (!isLightClass && systemPrefersDark)

@@ -60,7 +62,7 @@ export default function SignatureInput({
const observer = new MutationObserver(updateStrokeColor)
observer.observe(document.documentElement, {
attributes: true,
attributeFilter: ['class']
attributeFilter: ['class'],
})

const mediaQuery = window.matchMedia('(prefers-color-scheme: dark)')
@@ -83,6 +85,8 @@ export default function SignatureInput({
}

const stopDrawing = () => {
if (!isDrawing) return

setIsDrawing(false)
setLastPosition(null)
const canvas = canvasRef.current
5 changes: 4 additions & 1 deletion screens/form-builder/index.tsx
Original file line number Diff line number Diff line change
@@ -152,7 +152,10 @@ export default function FormBuilder() {
</div>
<div className="col-span-1 w-full h-full space-y-3">
<SpecialComponentsNotice formFields={formFields} />
<FormPreview formFields={formFields} />
<FormPreview
key={JSON.stringify(formFields)}
formFields={formFields}
/>
</div>
</div>
)}
18 changes: 13 additions & 5 deletions screens/generate-code-parts/index.tsx
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ export const generateZodSchema = (
fieldSchema = z.coerce.number()
break
} else {
fieldSchema = z.string()
fieldSchema = z.string().min(1, 'Required')
break
}
case 'Location Input':
@@ -58,7 +58,7 @@ export const generateZodSchema = (
})
break
case 'Smart Datetime Input':
fieldSchema = z.date()
fieldSchema = z.union([z.string(), z.date()])
break
case 'Number':
fieldSchema = z.coerce.number()
@@ -75,9 +75,10 @@ export const generateZodSchema = (
fieldSchema = z
.array(z.string())
.nonempty('Please select at least one item')
break
case 'Ratings':
fieldSchema = z.coerce.number({
required_error: 'Rating is required'
required_error: 'Rating is required',
})
break
default:
@@ -342,18 +343,25 @@ export const generateDefaultValues = (

// Handle field variants
switch (field.variant) {
case 'Checkbox':
case 'Switch':
defaultValues[field.name] = true
break
case 'Multi Select':
defaultValues[field.name] = ['React']
break
case 'Tags Input':
defaultValues[field.name] = []
break
case 'Datetime Picker':
case 'Smart Datetime Input':
case 'Date Picker':
defaultValues[field.name] = new Date()
break
case 'Rating':
defaultValues[field.name] = 0
defaultValues[field.name] = '0'
break
case 'Slider':
defaultValues[field.name] = 5
break
}
})
42 changes: 22 additions & 20 deletions screens/render-form-field/index.tsx
Original file line number Diff line number Diff line change
@@ -118,8 +118,9 @@ export const renderFormField = (field: FormFieldType, form: any) => {
const [selectedValues, setSelectedValues] = useState<string[]>(['React'])
const [tagsValue, setTagsValue] = useState<string[]>([])
const [files, setFiles] = useState<File[] | null>(null) // Initialize to null or use [] for an empty array
const [date, setDate] = useState<Date>()
const [datetime, setDatetime] = useState<Date>()
const [sliderValue, setSliderValue] = useState<number[]>([5])
const [date, setDate] = useState<Date | undefined>(new Date())
const [datetime, setDatetime] = useState<Date | undefined>(new Date())
const [smartDatetime, setSmartDatetime] = useState<Date | null>()
const [countryName, setCountryName] = useState<string>('')
const [stateName, setStateName] = useState<string>('')
@@ -318,6 +319,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
</FileUploader>
</FormControl>
<FormDescription>{field.description}</FormDescription>
<FormMessage />
</FormItem>
)
case 'Input':
@@ -371,7 +373,10 @@ export const renderFormField = (field: FormFieldType, form: any) => {
}}
onStateChange={(state) => {
setStateName(state?.name || '')
form.setValue(field.name, [form.getValues(field.name)[0] || '', state?.name || ''])
form.setValue(field.name, [
form.getValues(field.name)[0] || '',
state?.name || '',
])
}}
/>
<FormDescription>{field.description}</FormDescription>
@@ -381,7 +386,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
case 'Multi Select':
return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<MultiSelector
values={selectedValues}
@@ -414,7 +419,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
return (
<FormItem>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<Select onValueChange={field.onChange} defaultValue="[email protected]">
<Select onValueChange={field.onChange}>
<FormControl>
<SelectTrigger>
<SelectValue placeholder="Select a verified email to display" />
@@ -438,15 +443,15 @@ export const renderFormField = (field: FormFieldType, form: any) => {

return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<Slider
min={min}
max={max}
step={step}
defaultValue={[defaultValue]}
value={sliderValue}
onValueChange={(value) => {
setValue(value[0])
setSliderValue(value)
}} // Update to set the first value as a number
/>
</FormControl>
@@ -460,12 +465,12 @@ export const renderFormField = (field: FormFieldType, form: any) => {
case 'Signature Input':
return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<SignatureInput
canvasRef={canvasRef}
onSignatureChange={(signature) => {
if (signature) field.onChange(signature)
form.setValue(field.name, signature || undefined)
}}
/>
</FormControl>
@@ -478,7 +483,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
case 'Smart Datetime Input':
return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<SmartDatetimeInput
locale={field.locale as any}
@@ -515,16 +520,13 @@ export const renderFormField = (field: FormFieldType, form: any) => {
}}
/>
</FormControl>
<FormMessage />
</FormItem>
)
case 'Tags Input':
const currentTags = Array.isArray(form.watch(field.name))
? form.watch(field.name)
: []

return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<TagsInput
value={tagsValue}
@@ -545,7 +547,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
case 'Textarea':
return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<Textarea
placeholder={field.placeholder}
@@ -560,7 +562,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
case 'Password':
return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<PasswordInput
value={password}
@@ -581,7 +583,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
case 'Phone':
return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<PhoneInput
defaultCountry="TR"
@@ -600,7 +602,7 @@ export const renderFormField = (field: FormFieldType, form: any) => {
case 'Rating':
return (
<FormItem>
<FormLabel>{field.label}</FormLabel>
<FormLabel>{field.label}</FormLabel> {field.required && '*'}
<FormControl>
<Rating
value={rating}