feat: add support for PublishBlockStream to simulator
#548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
georgi-l95
commented
Jan 28, 2025
| * tracks processed blocks, and maintains a history of stream statuses. It provides functionality | ||
| * to start, monitor, and shutdown the gRPC server. | ||
| */ | ||
| public class PublishStreamGrpcServerImpl implements PublishStreamGrpcServer { |
There was a problem hiding this comment.
All implementations could be unified under one interface, that means that we close the idea of starting couple of implementations under one instance. Which is okay, judging by the current and future needs.
| * @param publishStreamRequest The incoming stream request to process | ||
| */ | ||
| @Override | ||
| public void onNext(PublishStreamRequest publishStreamRequest) { |
There was a problem hiding this comment.
In future PRs we will add handlers here to respond, depending on predefined configuration or depending on controller (don't exist yet). For now we have only one handler, which returns block ack.
| @@ -148,8 +134,10 @@ public void stop() throws InterruptedException { | |||
| public StreamStatus getStreamStatus() { | |||
| return StreamStatus.builder() | |||
| .publishedBlocks(publishStreamGrpcClient.getPublishedBlocks()) | |||
| .processedBlocks(publishStreamGrpcServer.getProcessedBlocks()) | |||
There was a problem hiding this comment.
If all grpc implementations are unifed under one interface, this could be improved and reduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for
PublishBlockStreamin the simulator, by introducing new wokring mode, called PublisherServerMode, where the application acts a server, which listents and awaits stream of block data. With the effort here I aim mainly to introduce the feature, where in future ones we will refine it, according to needs to be able to use it as testing driver.Related issue(s):
Fixes #430
Notes for reviewer:
Checklist