fix: fixtures usage example #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Jasuwienas <[email protected]>
|
arianejasuwienas
requested review from
georgi-l95,
Ivo-Yankov and
a team
as code owners
arianejasuwienas
added
ArianeLabs
|
Hi @arianejasuwienas, thanks for sending this. Could you please fill in the PR description? So we are aware what motivated this change. |
acuarica
requested changes
Aug 5, 2024
|
Hey @arianejasuwienas, there are some outstanding comments. Would you be able to address them so we can merge this? |
…fore test clause. Signed-off-by: Mariusz Jasuwienas <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
==========================================
+ Coverage 77.06% 82.63% +5.57%
==========================================
Files 40 47 +7
Lines 3266 3456 +190
Branches 683 731 +48
==========================================
+ Hits 2517 2856 +339
+ Misses 529 373 -156
- Partials 220 227 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enhance the Waffle usage example by adding additional code that demonstrates how Waffle Fixtures can be utilized.
Related issue(s):
#2882
Checklist