-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixtures usage example #2704
Conversation
Signed-off-by: Mariusz Jasuwienas <[email protected]>
|
Hi @arianejasuwienas, thanks for sending this. Could you please fill in the PR description? So we are aware what motivated this change. |
Hey @arianejasuwienas, there are some outstanding comments. Would you be able to address them so we can merge this? |
…fore test clause. Signed-off-by: Mariusz Jasuwienas <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
==========================================
+ Coverage 77.06% 82.63% +5.57%
==========================================
Files 40 47 +7
Lines 3266 3456 +190
Branches 683 731 +48
==========================================
+ Hits 2517 2856 +339
+ Misses 529 373 -156
- Partials 220 227 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description:
Enhance the Waffle usage example by adding additional code that demonstrates how Waffle Fixtures can be utilized.
Related issue(s):
#2882
Checklist