Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM Precompiles support #524

Merged
merged 12 commits into from
Nov 8, 2023
Merged

EVM Precompiles support #524

merged 12 commits into from
Nov 8, 2023

Conversation

ebadiere
Copy link
Contributor

@ebadiere ebadiere commented Oct 23, 2023 •
edited
Loading

EVM Precompiles support.

Fixes #496

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Test Results

195 tests   - 3   189 ✔️  - 2   7m 39s ⏱️ -3s
  63 suites  - 1       6 💤 ±0 
  14 files   ±0       0 ❌  - 1 

Results for commit 49791da. ± Comparison against base commit ab035ef.

This pull request removes 3 tests. 
should create a new snapshot and emit a Snapshot event ‑ ERC20ExtensionsMock tests ERC20Snapshot tests should create a new snapshot and emit a Snapshot event
should return the correct balanceOfAt(address, snapshotId) ‑ ERC20ExtensionsMock tests ERC20Snapshot tests should return the correct balanceOfAt(address, snapshotId)
should return the correct totalSupplyAt(snapshotId) ‑ ERC20ExtensionsMock tests ERC20Snapshot tests should return the correct totalSupplyAt(snapshotId)

♻️ This comment has been updated with latest results.

@ebadiere ebadiere marked this pull request as ready for review October 27, 2023 13:21
Nana-EC
Nana-EC reviewed Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Some nits

contracts/evm/Precompiles.sol Outdated Show resolved Hide resolved
test/evm/Precompiles.js Outdated Show resolved Hide resolved
@ebadiere
Applied feedback.
83b28b9 
Signed-off-by: ebadiere <[email protected]>
Nana-EC
Nana-EC reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
One missing file and a nit

package.json Show resolved Hide resolved
test/evm/Precompiles.js Outdated
expect(result[0]).to.equal("0xba80a53f981c4d0d6a2797b69f12f6e94c212f14685ac4b74b12bb6fdbffa2d1")
expect(result[1]).to.equal("0x7d87c5392aab792dc252d5de4533cc9518d38aa8dbf1925ab92386edd4009923")
});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I see this extra line before the final closing bracket in many places

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@ebadiere
Applied feedback.
49791da 
Signed-off-by: ebadiere <[email protected]>
@ebadiere ebadiere self-assigned this Nov 7, 2023
@ebadiere ebadiere added the enhancement New feature or request label Nov 7, 2023
@ebadiere ebadiere added this to the 0.7.0 milestone Nov 7, 2023
@ebadiere ebadiere merged commit 5944191 into main Nov 8, 2023
20 of 21 checks passed
@ebadiere ebadiere deleted the 496-EVM-precompiles-support branch November 8, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87

@AleksandrinaAleksieva AleksandrinaAleksieva Awaiting requested review from AleksandrinaAleksieva

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@yiliev0 yiliev0 Awaiting requested review from yiliev0 yiliev0 is a code owner

Assignees

@ebadiere ebadiere

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

EVM precompiles support
2 participants
@ebadiere @Nana-EC