-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vault: support k8s auth method #1580
Conversation
6928d41
to
aa8c510
Compare
Cosmetic change Improve docs
f9ad2fa
to
54cf5e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9ff66bf
to
2d1f6fb
Compare
Define k8s params in main config Define mapstructure tags
2d1f6fb
to
6f893c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tested with auth role
@eikenb Hi. Is everything okay with the implementation? Or do I need to fix something? |
Hey @Kryvchun, sorry for the silence. I was planning on working on this when I got to working on Envconsul which took a little longer than expected but I did start working on a new release for it this week and I plan on reviewing this as part of that (so I can loop it into the Envconsul release). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and checks all the required boxes, thanks @Kryvchun!
Thanks also for the help reviewing and testing @ygworldr, @yellowmegaman!!! Super appreciate that as I have limited time to validate the k8ts side of things.
You can configure (inside
Token:
There is no docs for this in |
Good day. @Kryvchun and @eikenb I have a problem with your update. Previously we are using VaultClient in a init_container for take a token from vault and consul-template for took a secret and rotate access to vault. But we need connect to vault always because we are have dynamic env. I made update to your commit. Its working well, consul take all secret from vault but we are lose token in 1h. I turned on the trace log for debug it. consul-template don`t rotate the token. its update block code
and vault accessor. You can see its not rotating.
Thanks for your time |
Issue: hashicorp/envconsul#274
This PR implements support of K8S auth method:
This can't be integration tested, so I mocked one endpoint (
/v1/auth/kubernetes/login
) with an*httptest.Server
, all other calls are proxied to Vault