[CLC-427][CLC-428]: Remove Data Migrations in Progress List and Status Map Usages #424
Conversation
kutluhanmetin
commented
Nov 2, 2023
•
kutluhanmetin
commented
- Remove Data Migrations in Progress List and Status Map Usages
- Refactor test files
- Add new stage "prechecks" to start command
- Wait for migration to be in STARTED status in start command
| Must(tcx.CLC().Execute(ctx, "cancel")) | ||
| }) | ||
| MustValue(l.Remove(ctx, serialization.JSON(m))) | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
We may have a problem if these tests don't work without sleeping.
There was a problem hiding this comment.
tbh, these tests are not enough anyway. I'll build the migration cluster build from the "remove in progress list" PR and try basic things.
There was a problem hiding this comment.
(also I don't get why we have sleep in this test, how mocking of migration cluster is done is complex for me. )
|
@kutluhanmetin The tests fail. Could you have a look? |
|
I have tried this version with the latest backend in the PR https://github.com/hazelcast/hazelcast-enterprise/pull/6765 The result of a dmt cancel when there's no migration in progress: 
I guess this error is not expected |
|
Status command when there's no migration: ➜ hazelcast-enterprise-5.3.5-DM-SNAPSHOT-slim ./dmt -c migration.yaml status Hazelcast Data Migration Tool v5.3.0 ERROR Could not connect to the migration cluster: finding migration in progress: no rows found |
|
when there was a migration and I canceled while it's in progress: 
This worked correctly except that the start command exited without any message. We should fix that as well (not related to this PR) |
|
Note: I approved because I retried all the scenarios above and all of them are fixed now. |
* add new stage "prechecks" to start command * wait for migration to be in STARTED status in start command
kutluhanmetin
changed the title
# Conflicts: # base/commands/migration/const.go # base/commands/migration/start_stages.go # base/commands/migration/utils.go
