Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLC-415]: add migration prerequisites #425

Closed
wants to merge 5 commits into from

Conversation

kutluhanmetin
Copy link
Contributor

No description provided.

@kutluhanmetin kutluhanmetin changed the base branch from main to dmt November 3, 2023 06:43
@kutluhanmetin kutluhanmetin requested review from yuce and srknzl November 3, 2023 06:43
Comment on lines 50 to 51
* Existing data structures on the target cluster will be skipped.
* It is recommended source cluster to be in read-only mode.
Copy link
Member

@srknzl srknzl Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Existing data structures on the target cluster will be skipped.
  • It is recommended source cluster to be in read-only mode.

It makes sense to move the last 2 under "Further Information" maybe. These are not prerequiesites.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Only a single migration can be run simultaneously.
* The target cluster must be an enterprise cluster or Viridian cluster.
* At least one data structure must be given in the migration configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say "atleast one data structure name must be provided in the migration configuration file"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's clearer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srknzl
Copy link
Member

srknzl commented Nov 6, 2023

This can be closed as part of the discussion at https://hazelcast.slack.com/archives/C053JA9B57H/p1699276227672769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants