Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLC-415]: add migration prerequisites #425

Closed
wants to merge 5 commits into from
Closed

[CLC-415]: add migration prerequisites #425

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
068edba
add migration prerequisites
kutluhanmetin Nov 3, 2023
a6f79c6
align with doc
kutluhanmetin Nov 3, 2023
d835735
fix PR comments
kutluhanmetin Nov 4, 2023
c46afd0
add Viridian item
kutluhanmetin Nov 6, 2023
481f271
remove typo
kutluhanmetin Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion base/commands/migration/migration_start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,16 @@ func (StartCmd) Exec(ctx context.Context, ec plug.ExecContext) (err error) {
ec.PrintlnUnnecessary(`Hazelcast Data Migration Tool v5.3.0
(c) 2023 Hazelcast, Inc.

Selected data structures in the source cluster will be migrated to the target cluster.
Selected data structures in the source cluster will be migrated to the target cluster.

Prerequisites:

* Only a single migration can be run simultaneously.
* The target cluster must be an enterprise cluster or Viridian cluster.
* At least one data structure must be given in the migration configuration.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say "atleast one data structure name must be provided in the migration configuration file"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's clearer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d835735

* The data structures given in the migration configuration must exist in the source cluster.
* Existing data structures on the target cluster will be skipped.
* It is recommended that the source cluster is put in read-only mode before the migration starts.
`)
if !ec.Props().GetBool(clc.FlagAutoYes) {
p := prompt.New(ec.Stdin(), ec.Stdout())
Expand Down
Loading