Fix test_published_images.yml [DI-316]
#827
Conversation
You could simply merge an empty (or minimalistic) workflow to the master, and then test the workflow on the branch |
| @@ -68,7 +68,7 @@ jobs: | |||
| variant: | |||
| - '' | |||
| - 'slim' | |||
| distribution_type: ${{ fromJson(needs.set-matrix.outputs.distribution-type-matrix) }} | |||
| distribution-type: ${{ fromJson(needs.set-matrix.outputs.distribution-type-matrix) }} | |||
There was a problem hiding this comment.
why this rename?
Consistency between the matrix name and its source. Probably not required but neater. Can revert if problematic…
I wasn’t sure what the eventual inputs would be (which is good as we changed them right at the end) and was worried GitHub would only let me use the inputs on |
I'm pretty sure it will show input from the PR branch |
The action added in #814 could not be properly tested via GitHub until merged and at that point additional defects were discovered. [Example of now successful completion](https://github.com/hazelcast/hazelcast-docker/actions/runs/11943342729). Fixes: [DI-316](https://hazelcast.atlassian.net/browse/DI-316) [DI-316]: https://hazelcast.atlassian.net/browse/DI-316?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
The action added in #814 could not be properly tested via GitHub until merged and at that point additional defects were discovered. [Example of now successful completion](https://github.com/hazelcast/hazelcast-docker/actions/runs/11943342729). Fixes: [DI-316](https://hazelcast.atlassian.net/browse/DI-316) [DI-316]: https://hazelcast.atlassian.net/browse/DI-316?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
The action added in #814 could not be properly tested via GitHub until merged and at that point additional defects were discovered. [Example of now successful completion](https://github.com/hazelcast/hazelcast-docker/actions/runs/11943342729). Fixes: [DI-316](https://hazelcast.atlassian.net/browse/DI-316) [DI-316]: https://hazelcast.atlassian.net/browse/DI-316?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
The action added in #814 could not be properly tested via GitHub until merged and at that point additional defects were discovered.
Example of now successful completion.
Post-merge actions:
Fixes: DI-316