Synthesis and P&R: Move closer to OpenROAD-flow-scripts #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthesis: This commit adds a custom abc.script from OpenROAD-flow-scripts. This commit also modifies the synthesis script. It adds 2 new steps: extract adders - it tries to map addition chains to PDK specific full adder and half adder improving overall performance. Runs only when `adder_mapping` attr is provided. tie logic cells - it runs `hilomap` pass. P&R: This commit changes output_db file extention to .odb. OpenROAD file explorer only allows for .odb to be opened from GUI. Allow user to disable `improve_placement` pass during resize step. It can cause cell overlapping both by not maintaining sufficient cell to cell spacing as well as true cell overlapping. Some other minor changes to the P&R scripts. Signed-off-by: Maciej Dudek <[email protected]>
mithro
reviewed
Dec 14, 2023
|
/gcbrun |
mithro
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Sorry about this, but I think we need this pull request split into the following;
enable_improve_placementfunctionality (should be quick to merge).dbinto.odb(should be quick to merge)estimate_parasiticsaddition (should be quick to merge)set_propagated_clock&detailed_routeaddition (may cause issues)remove_bufferschange (may cause issues)- Tie cell & hi/low change (may cause issues)
- Adder mapping (may cause issues)
- ABC script. (may cause issues)
Would you be able to do that?
| @@ -210,9 +210,9 @@ def openroad_command(ctx, commands, input_db = None, step_name = None, inputs = | |||
|
|
|||
There was a problem hiding this comment.
Can you send this changes in this file as a separate pull request. That can be quickly merged then.
There was a problem hiding this comment.
No problem, I'll split it into smaller changes
This was referenced Dec 14, 2023
Signed-off-by: Pawel Czarnecki <[email protected]>
This was referenced Dec 15, 2023
This was referenced Dec 18, 2023
|
I'm going to close this pull request as we are landing it in parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthesis:
This commit adds a custom abc.script from OpenROAD-flow-scripts. This commit also modifies the synthesis script. It adds 2 new steps: extract adders - it tries to map addition chains to PDK specific full adder and half adder improving overall performance. Runs only when
adder_mappingattr is provided.tie logic cells - it runs
hilomappass.P&R:
This commit changes output_db file extention to .odb. OpenROAD file explorer only allows for .odb to be opened from GUI.
Allow user to disable
improve_placementpass during resize step. It can cause cell overlapping both by not maintaining sufficient cell to cell spacing as well as true cell overlapping.Some other minor changes to the P&R scripts.
Edit:
Related to #239