Flux: Kustomization inventory showing all items with proper links #173
Conversation
mgalesloot
force-pushed
the
feature/kustomization-inventory
branch
from
d0183cf to
3af732b
Compare
There was a problem hiding this comment.
Most of the changes look good to me, but i saw that the inventory is missing some items and mostly resources which has a kind that we are not aware of for example kind = PolicyReport or kind = ClusterPolicy, we should show all these items. Also for an instance i saw that the inventory has 51 items but we are only showing 28 we are missing some of the inventory items(This is a seperate issue) but for this PR i think we should have atleast the unknowkn kind resources as well in the list.
|
In my local test environment ClusterPolicy is shown. See screenshot. But it is a good idea to show all items, even if we can't get query the resource. I will add a commit for that.
|
|
I have added a new commit to show also inventory resources that cannot be queried. |
* Kustomization inventory showing all items with proper links, without need for cluster wide privileges. * Refactor routes to include first part of apiVersion in the path, for consistent navigating from inventory. * Fixed depreaction warning "Route was found by path instead of name" Signed-off-by: Matthijs Galesloot <[email protected]>
Signed-off-by: Matthijs Galesloot <[email protected]>
mgalesloot
force-pushed
the
feature/kustomization-inventory
branch
from
6d37602 to
ac499b2
Compare
|
rebase completed |
mgalesloot
force-pushed
the
feature/kustomization-inventory
branch
from
a4949ce to
f57773f
Compare
Signed-off-by: Matthijs Galesloot <[email protected]>
mgalesloot
force-pushed
the
feature/kustomization-inventory
branch
from
4a6962f to
51a49d3
Compare
|
The changes for Event.default are already in the main, see commit 2db3fc7 |
|
Thank you so much @mgalesloot for this PR some really nice set of changes 🎉 |
Fixes #162