Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update claim btc to confirm btc #733

Merged
merged 2 commits into from
Jan 13, 2025
Merged

chore: update claim btc to confirm btc #733

merged 2 commits into from
Jan 13, 2025

Conversation

qgatssdev
Copy link
Contributor

@qgatssdev qgatssdev commented Jan 8, 2025 •
edited
Loading

Description

Update claimBtcDeposit to confirmBtcDeposit conforming with existing contract naming convention.

Closes #711

Checklist

  • Manual testing passed.
  • Automated tests added, or N/A.
  • Documentation updated, or N/A.
  • Environment variables set in CI, or N/A.

@gndelia
Copy link
Contributor

gndelia commented Jan 8, 2025 •
edited
Loading

@qgatssdev could you rebase your PR ? Your commits haven't been signed. You can check the docs

Thanks for your contribution 😄

@qgatssdev qgatssdev force-pushed the @qgatssdev/update-claimBtcDeposit-name branch from e514982 to b33c9ea Compare January 8, 2025 14:08
@qgatssdev
Copy link
Contributor Author

@qgatssdev could you rebase your PR ? Your commits haven't been signed. You can check the docs

Thanks for your contribution 😄

I just signed it, I believe everything should be fine now. I'm also looking forward to becoming an active contributor. I joined the discord but there was no contribution channel. I'll love to be assigned tasks and understand what we're building better.

gndelia
gndelia requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@gndelia gndelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qgatssdev I left you a comment, but other than that, I think it looks great. Thanks for your time!

webapp/hooks/useBtcTunnel.ts Outdated Show resolved Hide resolved
@qgatssdev qgatssdev requested a review from gndelia January 8, 2025 20:41
gndelia
gndelia previously approved these changes Jan 8, 2025
View reviewed changes
@qgatssdev
Copy link
Contributor Author

@qgatssdev I left you a comment, but other than that, I think it looks great. Thanks for your time!

@gndelia Can I get a link or Invite to the contributors discord? I have some questions on some Issues I want to work on.

ArturDolzan
ArturDolzan previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ArturDolzan ArturDolzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gabmontes
gabmontes previously approved these changes Jan 9, 2025
View reviewed changes
@gabmontes
Copy link
Contributor

It looks like there is a merge conflict with webapp/app/[locale]/tunnel/_components/claimBtcDeposit.tsx. This PR looks good but should be rebased.

@qgatssdev qgatssdev dismissed stale reviews from gabmontes, ArturDolzan, and gndelia via 4b54439 January 12, 2025 21:25
@qgatssdev qgatssdev force-pushed the @qgatssdev/update-claimBtcDeposit-name branch from a01c7a0 to 4b54439 Compare January 12, 2025 21:25
@qgatssdev
Copy link
Contributor Author

It looks like there is a merge conflict with webapp/app/[locale]/tunnel/_components/claimBtcDeposit.tsx. This PR looks good but should be rebased.

Done!

@gabmontes gabmontes merged commit 34b9a9f into hemilabs:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturDolzan ArturDolzan ArturDolzan approved these changes

@gabmontes gabmontes gabmontes approved these changes

@gndelia gndelia gndelia approved these changes

@alvarengathomas alvarengathomas Awaiting requested review from alvarengathomas

@rafappelt rafappelt Awaiting requested review from rafappelt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "claimBtcDeposit" naming to "confirmBtcDeposit"
4 participants
@qgatssdev @gndelia @gabmontes @ArturDolzan