Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email claim welcome pack #95

Merged
merged 8 commits into from
Mar 2, 2024
Merged

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented Mar 1, 2024

Closes #45

This PR

  • Adds the call to the webhook to send an email when the user claims a token. I had to reorganize the code so the timestamp would be sent and saved in our database as well
  • Added tests
  • Run these tests on GH
  • Added a fake lambda to use in local env as "sending emails" instead of using a webhook. I left it commented so it doesn't leak to prod (I'd rather have it fail locally rather than deploying this to aws). I tried this serverless plugin but it does not seem to work with serverless-offline (I left them an issue Does this work with serverless-offline? abemedia/serverless-disable-functions#259).
  • Added permissions to migrations-pg once it runs in aws

@gndelia gndelia self-assigned this Mar 1, 2024
@gndelia gndelia requested review from gabmontes and mbonfoster March 1, 2024 18:03
claim-tokens/serverless.yml Outdated Show resolved Hide resolved
claim-tokens/serverless.yml Show resolved Hide resolved
claim-tokens/db/emailSubmissions.js Outdated Show resolved Hide resolved
claim-tokens/config/prod.json Outdated Show resolved Hide resolved
claim-tokens/package.json Show resolved Hide resolved
marketing/README.md Outdated Show resolved Hide resolved
@gndelia gndelia requested a review from gabmontes March 1, 2024 22:53
@gndelia gndelia enabled auto-merge March 1, 2024 22:54
@gndelia gndelia merged commit 9da6933 into main Mar 2, 2024
6 checks passed
@gndelia gndelia deleted the send-email-claim-welcome-pack branch March 2, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement welcome pack
2 participants