Don't set processes when Procfile is present #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
force-pushed
the
jwl/prefer-procfile-processes
branch
from
25610f5 to
586dc16
Compare
colincasey
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Dec 12, 2024
This change treats the presence of a `Procfile` as the "source of truth" for how processes should be registered and will skip the default process registration that was previously performed for `npm`, `yarn`, and `pnpm`. Fixes #908 Related to heroku/buildpacks-go#319
colincasey
reviewed
Dec 12, 2024
colincasey
reviewed
Dec 12, 2024
colincasey
approved these changes
Dec 12, 2024
colincasey
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Dec 13, 2024
* Skip default process registration when Procfile is present This change treats the presence of a `Procfile` as the "source of truth" for how processes should be registered and will skip the default process registration that was previously performed for `npm`, `yarn`, and `pnpm`. Fixes #908 Related to heroku/buildpacks-go#319 * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers are often surprised and sometimes annoyed when this buildpack adds processes not in the
Procfile. This prevents adding processes when aProcfileis present.In the future, I'd like to change this conditional to be dependent on
heroku/procfilecontributing, rather than the specificProcfilefile.Related: #85
GUS