Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make state config mockable #672

Merged
merged 3 commits into from
Jan 11, 2024
Merged

test: make state config mockable #672

merged 3 commits into from
Jan 11, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 10, 2024

No description provided.

@phm07 phm07 self-assigned this Jan 10, 2024
@phm07 phm07 requested a review from a team as a code owner January 10, 2024 13:13
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5e871d) 46.35% compared to head (68a7918) 45.51%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   46.35%   45.51%   -0.84%     
==========================================
  Files         179      179              
  Lines        7879     7879              
==========================================
- Hits         3652     3586      -66     
- Misses       3767     3837      +70     
+ Partials      460      456       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/state/config/config.go Outdated Show resolved Hide resolved
internal/hcapi2/mock/mock_gen.go Outdated Show resolved Hide resolved
@phm07 phm07 merged commit a25017e into main Jan 11, 2024
3 checks passed
@phm07 phm07 deleted the config-mockable branch January 11, 2024 13:31
phm07 added a commit that referenced this pull request Jan 11, 2024
The config file was not read properly because `rawConfig` fields were
made unexported in a previous PR (#672)

BEGIN_COMMIT_OVERRIDE
test: make state config mockable
END_COMMIT_OVERRIDE
phm07 added a commit that referenced this pull request Mar 12, 2024
This file was erroneously deleted in #672
@phm07 phm07 mentioned this pull request Mar 12, 2024
phm07 added a commit that referenced this pull request Mar 12, 2024
This file was erroneously deleted in #672

Co-authored-by: pauhull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants