-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make state config mockable #672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 46.35% 45.51% -0.84%
==========================================
Files 179 179
Lines 7879 7879
==========================================
- Hits 3652 3586 -66
- Misses 3767 3837 +70
+ Partials 460 456 -4 ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
Jan 10, 2024
apricote
reviewed
Jan 10, 2024
phm07
force-pushed
the
config-mockable
branch
from
January 10, 2024 13:31
fe0833b
to
5cf727f
Compare
phm07
force-pushed
the
config-mockable
branch
from
January 10, 2024 13:40
5cf727f
to
d89a322
Compare
apricote
approved these changes
Jan 11, 2024
phm07
added a commit
that referenced
this pull request
Jan 11, 2024
The config file was not read properly because `rawConfig` fields were made unexported in a previous PR (#672) BEGIN_COMMIT_OVERRIDE test: make state config mockable END_COMMIT_OVERRIDE
phm07
added a commit
that referenced
this pull request
Mar 12, 2024
This file was erroneously deleted in #672
phm07
added a commit
that referenced
this pull request
Mar 12, 2024
This file was erroneously deleted in #672 Co-authored-by: pauhull <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.