v3 of the editor #9288
Open
v3 of the editor #9288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… closer to having it implemented in all places.
- another component ported to MarkdownViewer - can compare layout to quill now.
…re not currently working.
… we have so we should be good.
# Conflicts: # packages/commonwealth/client/scripts/views/components/NewThreadForm/NewThreadForm.tsx # packages/commonwealth/package.json # pnpm-lock.yaml
# Conflicts: # packages/commonwealth/client/scripts/views/components/component_kit/new_designs/CWSearchBar/SearchBarCommentPreviewRow.tsx # packages/commonwealth/client/scripts/views/components/component_kit/new_designs/CWSearchBar/SearchBarThreadPreviewRow.tsx # packages/commonwealth/client/scripts/views/pages/Snapshots/ViewSnapshotProposal/ViewSnapshotProposal.tsx
# Conflicts: # packages/commonwealth/client/scripts/views/components/NewThreadForm/NewThreadForm.tsx
|
@burtonator Mobile issues tested on iphone:
153378AA-24C2-4292-B485-0D97E3D72673.MP4 |
# Conflicts: # packages/commonwealth/client/scripts/views/components/NewThreadForm/NewThreadForm.tsx
|
@masvelio The browser you used is mobile Safari right ? I don't get those issues on Chrome but I do get some different issues. I'll pull out my tablet/iphone and test there too but I'm going to do it in v4. Could you approve this PR though so we can push forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also duplicates NewThreadForm into NewThreadFormLegacy and NewThreadFormModern so you don't really need to fully audit those two as NewThreadFormModern is the main one and most of the code didn't change.
Also, everything here should be safely behind a feature toggle so nothing is being turned on yet.
I have 1-2 more revisions to go before we can turn it on.
Link to Issue
Closes: #9290
Also fixes issues:
Description of Changes
"How We Fixed It"
Test Plan
The test plan is in the README.md but here is the list.
I would not do this yet though. We can do a full QA and test of everything right before we're ready to turn everything on next week.
Desktop
success: copy a .md file to the clipboard, try to paste it into the editor. It
should insert the content at the editor's cursor
success: drag a .md file on top of the editor. The drag indicator should show
up and cover the editor while you're dragging. Then the file should be inserted
at the cursor.
success: use the 'Import markdown' button to upload a file.
success: right click and copy an image in the browser, this should upload it
to the editor and insert it at the current point (I use msnbc.com for this as
their images are copyable and not CSS background images)
success: take a screenshot, try to paste it into the editor. The upload
indicator should show up.
success: use the image button at the top to manually upload an image. The
upload indicator should show up while this is happening.
success: drop an image file. Should upload it for us and not handle it as
markdown.
failure: copy multiple .md files ot the clipboard, try to paste into the editor.
It should fail because we can't handle multiple .md files
Mobile
It's probably best to test this on a REAL mobile browser (not on a desktop).
The toolbar should be present at the bottom of the UI.
They keyboard should stay on top of the keyboard.
Viewer
Deployment Plan
Other Considerations