Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 of the editor #9288

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

v3 of the editor #9288

wants to merge 53 commits into from

Commits on Sep 13, 2024

  1. use a new image strategy which does not require a dialog

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9f02a36 View commit details
    Browse the repository at this point in the history

  2. Fixed the CWIcons...

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7b878bf View commit details
    Browse the repository at this point in the history

  3. making a new file upload button...

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4cd0b9d View commit details
    Browse the repository at this point in the history

  4. cleanup of buttons.

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    755b4e9 View commit details
    Browse the repository at this point in the history

  5. improved desktop footer.

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b4850c1 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    29f70f1 View commit details
    Browse the repository at this point in the history

  7. Fixed spacing.

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d101565 View commit details
    Browse the repository at this point in the history

  8. The mobile keyboard adjustment should work now.

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    52776b3 View commit details
    Browse the repository at this point in the history

  9. We switch to the new viewer now..

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f9b930d View commit details
    Browse the repository at this point in the history

  10. ability to expand toggle the content.

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    238abcc View commit details
    Browse the repository at this point in the history

  11. The cutoff now works...

    @burtonator
    burtonator committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    720c3c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. I still have a few features to fix in the markdown viewer but this is… 

    … closer to having it implemented in all places.
    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0b50728 View commit details
    Browse the repository at this point in the history

  2. - fixed table layout, compared to quill 

    - another component ported to MarkdownViewer
- can compare layout to quill now.
    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    16271ce View commit details
    Browse the repository at this point in the history

  3. show more link types in the supported example to verify that embeds a… 

    …re not currently working.
    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2fe3d57 View commit details
    Browse the repository at this point in the history

  4. - added the custom view button onw

    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    eee2d1f View commit details
    Browse the repository at this point in the history

  5. - killed off another two uses...

    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1633006 View commit details
    Browse the repository at this point in the history

  6. added new className...

    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9113dad View commit details
    Browse the repository at this point in the history

  7. this should work as a hit highlighter now... It's the existing system… 

    … we have so we should be good.
    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c7c0db4 View commit details
    Browse the repository at this point in the history

  8. this should work now...

    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    17540d6 View commit details
    Browse the repository at this point in the history

  9. use the new markdown viewer or the fallback.

    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    936c2c9 View commit details
    Browse the repository at this point in the history

  10. new component for rendering withi fallback.

    @burtonator
    burtonator committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b5ca1f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Ability to render search hits now.

    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ca8359e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/master' into burton/editor-v3 

    # Conflicts:
#	packages/commonwealth/client/scripts/views/components/NewThreadForm/NewThreadForm.tsx
#	packages/commonwealth/package.json
#	pnpm-lock.yaml
    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    66833fe View commit details
    Browse the repository at this point in the history

  3. Fixed pnpmp lock issue.

    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a273b5d View commit details
    Browse the repository at this point in the history

  4. Working on making the editor support active/inactive...

    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    09f0a75 View commit details
    Browse the repository at this point in the history

  5. make the editor more like the current editor and we can revise the UX… 

    … later.
    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    eebb5e2 View commit details
    Browse the repository at this point in the history

  6. Fixed bug in table layout.

    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    489d599 View commit details
    Browse the repository at this point in the history

  7. the editor can pass back a ref to getMarkdown now

    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    19c80f4 View commit details
    Browse the repository at this point in the history

  8. adding support for changing the button.

    @burtonator
    burtonator committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3eca3f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Refactored so that the button can be a component.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0758192 View commit details
    Browse the repository at this point in the history

  2. have a context for the manually set mode...

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    708a300 View commit details
    Browse the repository at this point in the history

  3. Made the error handler work with errors now.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c6360c6 View commit details
    Browse the repository at this point in the history

  4. new thread creation works now.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fcdc5fd View commit details
    Browse the repository at this point in the history

  5. The new thread form should basically be setup correctly.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e4f08e5 View commit details
    Browse the repository at this point in the history

  6. new on change ...

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    33fd53c View commit details
    Browse the repository at this point in the history

  7. new components for the modern version.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2669e0a View commit details
    Browse the repository at this point in the history

  8. renamed to legacy ...

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    59a3eeb View commit details
    Browse the repository at this point in the history

  9. old code removed...

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4666a8f View commit details
    Browse the repository at this point in the history

  10. ok we can select the older one now...

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    38fe5e1 View commit details
    Browse the repository at this point in the history

  11. No quill usage.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b3931b7 View commit details
    Browse the repository at this point in the history

  12. change the draft version as the type has changed.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ed18a5d View commit details
    Browse the repository at this point in the history

  13. Fixed an error found by Marcin.

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5e921a7 View commit details
    Browse the repository at this point in the history

  14. removed FIXME

    @burtonator
    burtonator committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a4c0868 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'refs/heads/master' into burton/editor-v3 

    # Conflicts:
#	packages/commonwealth/client/scripts/views/components/component_kit/new_designs/CWSearchBar/SearchBarCommentPreviewRow.tsx
#	packages/commonwealth/client/scripts/views/components/component_kit/new_designs/CWSearchBar/SearchBarThreadPreviewRow.tsx
#	packages/commonwealth/client/scripts/views/pages/Snapshots/ViewSnapshotProposal/ViewSnapshotProposal.tsx
    @burtonator
    burtonator committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6fc5987 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/burton/editor-v2' into burton/editor-v3 

    # Conflicts:
#	packages/commonwealth/client/scripts/views/components/NewThreadForm/NewThreadForm.tsx
    @burtonator
    burtonator committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fbcd6e2 View commit details
    Browse the repository at this point in the history

  3. Fixed type issue...

    @burtonator
    burtonator committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e6322ba View commit details
    Browse the repository at this point in the history

  4. Fixed build issues...

    @burtonator
    burtonator committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ffa59cc View commit details
    Browse the repository at this point in the history

  5. Fixed issue with the tooltip which I'm going to support in v4.

    @burtonator
    burtonator committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1f04e94 View commit details
    Browse the repository at this point in the history

  6. Fixed eslint issues.

    @burtonator
    burtonator committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    378341a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'refs/heads/master' into burton/editor-v3

    @burtonator
    burtonator committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    22ebd24 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'refs/heads/master' into burton/editor-v3 

    # Conflicts:
#	packages/commonwealth/client/scripts/views/components/NewThreadForm/NewThreadForm.tsx
    @burtonator
    burtonator committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e75f1ab View commit details
    Browse the repository at this point in the history

  2. ported back marcin's changed to the old form.

    @burtonator
    burtonator committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    226aa5f View commit details
    Browse the repository at this point in the history

  3. Fixed for the modern version.

    @burtonator
    burtonator committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1bd03c3 View commit details
    Browse the repository at this point in the history