Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed “value” to “volume” in OHLCV. #27

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Eskils
Copy link
Contributor

@Eskils Eskils commented Aug 30, 2024

From Morningstar’s website, it looks like V stands for Volume in OHLCV.

Screenshot 2024-08-30 at 12 58 25

@Eskils Eskils requested a review from bre1470 August 30, 2024 11:48
@bre1470 bre1470 added this to the Next milestone Aug 30, 2024
@bre1470 bre1470 changed the title Change “value” to “volume” in OHLCV Changed “value” to “volume” in OHLCV. Aug 30, 2024
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@bre1470 bre1470 merged commit de782d1 into main Aug 30, 2024
3 checks passed
@bre1470 bre1470 deleted the feature/rename-value-to-volume-in-ohlcv branch August 30, 2024 16:32
@bre1470 bre1470 added the bugfix Something isn't working label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants