draft: lsp format #1632
Draft
draft: lsp format #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
commented
Dec 19, 2024
| @@ -23,7 +23,7 @@ declare const __EXTENSION_URL__: string; | |||
| new BrowserMessageWriter(self), | |||
| ); | |||
|
|
|||
| initSync(await wasmModule); | |||
| initSync({ module: await wasmModule }); | |||
There was a problem hiding this comment.
fixes a warning i saw in the console. Not mandatory but will probably be needed in the future
hugocaillard
commented
Dec 19, 2024
| @@ -26,7 +26,6 @@ use std::sync::{Arc, RwLock}; | |||
| use wasm_bindgen::prelude::*; | |||
| use wasm_bindgen_futures::future_to_promise; | |||
|
|
|||
| #[cfg(debug_assertions)] | |||
There was a problem hiding this comment.
Not that println! won't be visible in wasm.
I just removed #[cfg(debug_assertions)] for debugging, don't remember how to enable it
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking change?
Example
Checklist