NGR-1091 - Amended Landlord page to yes/no radio buttons #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NGRCharacterCount( | ||
| id = "landlord-radio-other", | ||
| name = "landlord-radio-other", | ||
| id = "landlord-yes", |
There was a problem hiding this comment.
This can be confused with the yes radio button id. What do you think of landlord-relationship?
| import uk.gov.hmrc.ngrraldfrontend.models.forms.mappings.Mappings | ||
|
|
||
| final case class LandlordForm(landlordName: String, landLordType: String, landlordOther: Option[String]) | ||
| final case class LandlordForm(landlordName: String, landLordType: String, landlordYesSelected: Option[String]) |
There was a problem hiding this comment.
Can you please change landType to hasRelationship or something? Can you please store as Boolean
Maybe landlordRelationship or relationshipWithLandlord?
| val rentBasedOnForm = input.asInstanceOf[LandlordForm] | ||
| if (rentBasedOnForm.landLordType.equals("OtherRelationship") && rentBasedOnForm.landlordOther.getOrElse("").isBlank) | ||
| if (rentBasedOnForm.landLordType.equals("LandlordYes") && rentBasedOnForm.landlordYesSelected.getOrElse("").isBlank) | ||
| Invalid(otherRadioEmptyError) |
There was a problem hiding this comment.
Can you please change the value name as other radio doesn't exist any more?
| val rentBasedOnForm = input.asInstanceOf[LandlordForm] | ||
| if (rentBasedOnForm.landLordType.equals("OtherRelationship") && rentBasedOnForm.landlordOther.getOrElse("").length > 250) | ||
| if (rentBasedOnForm.landLordType.equals("LandlordYes") && rentBasedOnForm.landlordYesSelected.getOrElse("").length > 250) | ||
| Invalid(otherRadioTooLongError) |
There was a problem hiding this comment.
Can you please change the error value name?
| landlord.name.empty.tooLong.error = Landlord''s full name must be 50 characters or less | ||
| landlord.radio.empty.error = Select what your relationship with the landlord is | ||
| landlord.radio.other.empty.error = Tell us what your relationship with the landlord is | ||
| landlord.radio.yes = Can you tell us what your relationship with the landlord is? |
There was a problem hiding this comment.
Can you please remove unused ones? eg. landlord.radio1
| } | ||
|
|
||
| def validate(form: LandlordForm): Boolean = { | ||
| form.landLordType != "OtherRelationship" || |
There was a problem hiding this comment.
Landlord type would never be OtherRelationship.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.