Drop support for python versions <3.9 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
approved these changes
Mar 19, 2025
| @@ -89,7 +89,7 @@ jobs: | |||
| run: | | |||
| MATRIX=$(jq -nsc '{ | |||
| "os": ["ubuntu-latest", "macos-latest", "windows-latest"], | |||
| "environment": ["test-38", "test-39", "test-310", "test-311", "test-312"], | |||
| "environment": ["test-39", "test-310", "test-311", "test-312"], | |||
There was a problem hiding this comment.
We should likely update to add test-313, though let's do this in another PR.
There was a problem hiding this comment.
Agree, @Azaya89 can you open another PR? Replacing 3.13 with 3.12 in the default case and adding 3.13 in the full case. After that, we should be able to proceed with a release.
There was a problem hiding this comment.
OK. although the test-core env uses 3.13
There was a problem hiding this comment.
Yes, the distinction isn't that important for Colorcet, but for other packages, the core is the absolute minimum of dependency (so we can check the latest), whereas test-3XX has a lot of dependencies (which can have pins on other dependencies).
maximlt
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #130