Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python versions <3.9 #131

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Drop support for python versions <3.9 #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
run: |
MATRIX=$(jq -nsc '{
"os": ["ubuntu-latest", "macos-latest", "windows-latest"],
"environment": ["test-38", "test-39", "test-310", "test-311", "test-312"],
"environment": ["test-39", "test-310", "test-311", "test-312"],
Copy link
Member

@hoxbro hoxbro Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should likely update to add test-313, though let's do this in another PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, @Azaya89 can you open another PR? Replacing 3.13 with 3.12 in the default case and adding 3.13 in the full case. After that, we should be able to proceed with a release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. although the test-core env uses 3.13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the distinction isn't that important for Colorcet, but for other packages, the core is the absolute minimum of dependency (so we can check the latest), whereas test-3XX has a lot of dependencies (which can have pins on other dependencies).

}')
echo "MATRIX=$MATRIX" >> $GITHUB_ENV

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ by Peter Kovesi at the Center for Exploration Targeting.

## Installation

Colorcet supports Python 3.7 and greater on Linux, Windows, or Mac
Colorcet supports Python 3.9 and greater on Linux, Windows, or Mac
and can be installed with conda:

```sh
Expand Down
2 changes: 1 addition & 1 deletion doc/getting_started/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Getting started
Installation
------------

Colorcet supports Python 3.7 and greater on Linux, Windows, or Mac
Colorcet supports Python 3.9 and greater on Linux, Windows, or Mac
and can be installed with conda::

conda install colorcet
Expand Down
7 changes: 0 additions & 7 deletions pixi.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ PYTHONIOENCODING = "utf-8"
[environments]
default = ["py312", "required", "test-core", "test", "example", "test-example", "lint", "dev"]

[environments.test-38]
features = ["py38", "required", "test-core", "test", "example", "test-example"]
no-default-feature = true

[environments.test-39]
features = ["py39", "required", "test-core", "test", "example", "test-example"]
no-default-feature = true
Expand Down Expand Up @@ -55,9 +51,6 @@ install = 'python -m pip install --no-deps --disable-pip-version-check -e .'
setup-dev = { depends-on = ["install", "lint-install"] }
sync-git-tags = 'python scripts/sync_git_tags.py colorcet'

[feature.py38.dependencies]
python = "3.8.*"

[feature.py39.dependencies]
python = "3.9.*"

Expand Down
7 changes: 2 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dynamic = ["version"]
description = "Collection of perceptually uniform colormaps"
readme = "README.md"
license = { text = "CC-BY License" }
requires-python = ">=3.7"
requires-python = ">=3.9"
authors = [
{ name = "James A. Bednar", email = "[email protected]" },
]
Expand All @@ -22,8 +22,6 @@ classifiers = [
"License :: OSI Approved",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -79,8 +77,7 @@ include-package-data = false
include = ["colorcet"]

[tool.setuptools_scm]
# Replace with version_file when Python 3.7 is dropped.
write_to = "colorcet/_version.py"
version_file = "colorcet/_version.py"

[tool.pytest.ini_options]
addopts = ["--strict-config", "--strict-markers", "--color=yes"]
Expand Down