compat: Bokeh 3.7 #6529
Merged
compat: Bokeh 3.7 #6529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
commented
Mar 7, 2025
| @@ -220,8 +220,12 @@ def test(): | |||
| assert s.xs == {'x': np.datetime64('2024-01-12T13:26:44.819277')} | |||
| assert s.xs == {'x': np.datetime64('2024-01-12T13:26:44.819277')} | |||
| assert len(s.ys) == 2 | |||
| assert np.isclose(s.ys["y1"], 18.130705394191) | |||
| assert np.isclose(s.ys["y2"], 76.551867219917) | |||
| if BOKEH_GE_3_7_0: | |||
There was a problem hiding this comment.
This is because the datetime x-axis has changed to add the year, squeezing the values a bit.
| Before | After |
|---|---|
 |
 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6529 +/- ##
==========================================
- Coverage 88.79% 88.79% -0.01%
==========================================
Files 323 323
Lines 68951 68955 +4
==========================================
+ Hits 61227 61229 +2
- Misses 7724 7726 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoxbro
commented
Mar 7, 2025
| @@ -414,6 +418,7 @@ async def popup_form(x, y): | |||
| locator = page.locator(".bk-btn") | |||
| expect(locator).to_have_count(2) | |||
|
|
|||
| @pytest.mark.filterwarnings("ignore:reference already known") | |||
There was a problem hiding this comment.
I tried to see if I could figure out where this was coming from but without luck. It is the button ID that is flagged.
import numpy as np
import panel as pn
import holoviews as hv
hv.extension("bokeh")
rng = np.random.default_rng(10)
points = hv.Points(rng.normal(size=(1000, 2)))
def popup_form(x, y):
def hide(_):
button.visible = False
button = pn.widgets.Button(name=f"{x},{y}", on_click=hide)
return button
points.opts(tools=["tap"])
hv.streams.Tap(source=points, popup=popup_form)
pn.panel(points).servable()There was a problem hiding this comment.
@philippjfr, you are welcome to give it a go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two failing UI tests.